Patient without MRN

mikemets · May 11, 2023, 3:10pm

Has any senaite.patient users switched off the “Require Medical Record Number (MRN)” setting? I switched it off but if I leave the MRN field blank when creating a patient, I get the error “Patient Medical Record is missing or empty”. Am I missing something or should I log an issue?

mikemets · May 11, 2023, 3:21pm

So I get the error when testing manually but when I extend Patients.rst with the test below, it creates a patient without the MRN

Create patient with no MRN should fail:
    >>> patient_api.is_patient_required()
    True
    >>> api.create(patients, "Patient")
    Traceback (most recent call last):
    >>> plone_api.portal.set_registry_record("senaite.patient.require_patient", False)
    >>> patient_api.is_patient_required()
    False
    >>> patient = api.create(patients, "Patient")
    >>> patient
    <Patient at /plone/patients/P000002>

ramonski · May 11, 2023, 8:14pm

Hi Mike,

yes, this is a bug in senaite.patient.

The check api.is_patient_required is missing here:

github.com

senaite/senaite.patient/blob/f87db24c1c552858c86e7dee14f8e0d66e799184/src/senaite/patient/content/patient.py#L324


      
          def validate_mrn(data):
              """Checks if the patient MRN # is unique
              """
              # https://community.plone.org/t/dexterity-unique-field-validation
              context = getattr(data, "__context__", None)
              if context is not None:
                  if context.mrn == data.mrn:
                      # nothing changed
                      return
          
          
    if not data.mrn:
                  raise Invalid(_("Patient Medical Record is missing or empty"))
          
          
    patient = patient_api.get_patient_by_mrn(
                  data.mrn, full_object=False, include_inactive=True)
          
          
    if patient:
                  raise Invalid(_("Patient Medical Record # must be unique"))
          
          
@invariant
          def validate_patient_id(data):

You can directly create a PR for this if possible.

Cheers, Ramon